#141680: "incorrect score display"
Hva handler denne rapporten om?
Hva har skjedd, eller hva gjelder det? Vennligst velg
Hva har skjedd, eller hva gjelder det? Vennligst velg
Vennligst sjekk om det allerede er en rapport om samme emne
Hvis ja, vennligst STEM på denne rapporten. Rapporter med flest stemmer er gitt PRIORITET!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Detaljert beskrivelse
-
• Vennligst kopier/lim inn feilmeldingen du ser på skjermen, om mulig.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Vennligst forklar hva du ønsket å gjøre, samt hva du faktisk gjorde og hva som skjedde
• Hvilken nettleser bruker du?
opera
-
• Vennligst kopier / lim inn teksten som vises på engelsk i stedet for språket ditt. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here. Er denne teksten tilgjengelig i translation system? Hvis ja, har den blitt oversatt i mer enn 24 timer?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hvilken nettleser bruker du?
opera
-
• Vennligst forklar ditt forslag nøyaktig og konsistent slik at det er så enkelt som mulig å forstå hva du mener.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hvilken nettleser bruker du?
opera
-
• Hva ble vist på skjermen når du ble blokkert (Tom skjerm? Del av spillgrensesnittet? Feilmelding?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hvilken nettleser bruker du?
opera
-
• Hvilken del av reglene ble ikke respektert av BGA-tilpasningen
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Er regelbruddet tydelig i spilloggen? Hvis ja, Hvilket trekknummer?
• Hvilken nettleser bruker du?
opera
-
• Hva var spillhandlingen du ønsket å gjøre?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Hva prøvde du å gjøre for å trigge denne spillhandlingen?
-
• Hva skjer når du prøver å gjøre dette (feilmelding, meldingsstatus for meldingsfelt, ...)?
• Hvilken nettleser bruker du?
opera
-
• På hvilket tidspunkt i spillet oppsto problemet (hva var den daværende spillinstruksjonen)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Hva skjer når du forsøker å gjøre en spillhandling (feilmelding, spillstatusfeltmelding, ...)?
• Hvilken nettleser bruker du?
opera
-
• Vennligst beskriv visningsproblemet. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hvilken nettleser bruker du?
opera
-
• Vennligst kopier / lim inn teksten som vises på engelsk i stedet for språket ditt. If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here. Er denne teksten tilgjengelig i translation system? Hvis ja, har den blitt oversatt i mer enn 24 timer?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hvilken nettleser bruker du?
opera
-
• Vennligst forklar ditt forslag nøyaktig og konsistent slik at det er så enkelt som mulig å forstå hva du mener.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Hvilken nettleser bruker du?
opera
Rapporthistorikk
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Legg til noe i denne rapporten
- En annen bord ID / flytt ID
- Løste F5 problemet?
- Oppstod problemet gjentatte ganger? Hver gang? Tilfeldig?
- If you have a screenshot of this bug (good practice), you can use a picture hosting service of your choice (snipboard.io for example) to upload it and copy/paste the link here.
